incron and simp_generate_types seems to kill master instance

Description

I have run into an issue that I can reproduce fairly easily in which the incron simp_generate_types under `pumod::master::generate_types` consumes all free memory on the master and crashes the machine

I ran a vagrant master on CentOS7 using RPM installation and basic SIMP configuration. Installed the `biemond-oradb` module using `puppet module install` just to get it up and running and subsequent puppet runs hang on:

`Notice: /Stage[main]/Pupmod::Master::Generate_types/Incron::System_table[simp_generate_types]/Incron_system_table[simp_generate_types]/ensure: created`

I didn't gather much as it's not a usable system afterwards; however, I was able to see some ps output. Stack traces with out of memory roll across the console.

— OUTPUT FROM PS CAUGHT AT TIME OF ISSUE —
root 9020 9018 0 21:29 ? 00:00:00 /opt/puppetlabs/puppet/bin/ruby /usr/local/sbin/simp_generate_types -p /etc/puppetlabs/code/environments/simp/data/.default.yaml.swp -s -d 30
root 9021 9019 0 21:29 ? 00:00:00 /opt/puppetlabs/puppet/bin/ruby /usr/local/sbin/simp_generate_types -p /etc/puppetlabs/code/environments/simp/data/.default.yaml.swp -s -d 30
root 9022 9016 0 21:29 ? 00:00:00 /opt/puppetlabs/puppet/bin/ruby /usr/local/sbin/simp_generate_types -p /etc/puppetlabs/code/environments/simp/data/.default.yaml.swp -s -d 30
root 9023 9017 0 21:29 ? 00:00:00 /opt/puppetlabs/puppet/bin/ruby /usr/local/sbin/simp_generate_types -p /etc/puppetlabs/code/environments/simp/data/.default.yaml.swx -s -d 30
root 9050 9049 0 21:29 ? 00:00:00 /opt/puppetlabs/puppet/bin/ruby /usr/local/sbin/simp_generate_types -p /etc/puppetlabs/code/environments/simp/data/.default.yaml.swp -s -d 30
root 9062 9058 0 21:29 ? 00:00:00 /opt/puppetlabs/puppet/bin/ruby /usr/local/sbin/simp_generate_types -p /etc/puppetlabs/code/environments/simp/data/4913 -s -d 30
root 9063 9059 0 21:29 ? 00:00:00 /opt/puppetlabs/puppet/bin/ruby /usr/local/sbin/simp_generate_types -p /etc/puppetlabs/code/environments/simp/data/default.yaml~ -s -d 30
root 9064 9060 0 21:29 ? 00:00:00 /opt/puppetlabs/puppet/bin/ruby /usr/local/sbin/simp_generate_types -p /etc/puppetlabs/code/environments/simp/data/default.yaml~ -s -d 30
root 9065 9061 0 21:29 ? 00:00:00 /opt/puppetlabs/puppet/bin/ruby /usr/local/sbin/simp_generate_types -p /etc/puppetlabs/code/environments/simp/data/default.yaml -s -d 30
root 9070 9066 0 21:29 ? 00:00:00 /opt/puppetlabs/puppet/bin/ruby /usr/local/sbin/simp_generate_types -p /etc/puppetlabs/code/environments/simp/data/.default.yaml.swp -s -d 30
— END OUTPUT OF PS —

When you set `pupmod::master::generate_types::enable` to false and uninstall/reinstall the module running `puppet generate types` manually there is no issue. If you re-enable and uninstall/reinstall the module it hangs again.

I included my vagrant configuration files on the ticket in case people want to use these to reproduce.

Acceptance Criteria

None

Activity

Show:
Trevor Vaughan
January 30, 2019, 2:47 PM

documentation update with full incron impact statement

Trevor Vaughan
January 25, 2019, 3:05 PM

Update for handling incron 0.5.12+

Trevor Vaughan
January 23, 2019, 9:44 PM

So, it looks like the 6.3.0-0 release had the older (working) version on incron included.

The patch available at https://github.com/simp/pupmod-simp-incron/pull/23 pins the incron version appropriately for both EL6 and EL7.

I would suggest also adding a yum::versionlock to ensure that any systems do not update that package as well as removing it from all repositories if possible.

Trevor Vaughan
January 23, 2019, 9:03 PM

This looks like identification of the original issue: https://bugzilla.redhat.com/show_bug.cgi?id=1656939

No idea when the patched version might end up in EPEL.

Trevor Vaughan
January 23, 2019, 7:22 PM
Done

Labels

None

Epic Link

None

Story Points

8

Components

Sprint

None

Affects versions

Priority

Highest