Clean up the simp_bolt plan that installs puppet-agent

Description

Following on from https://github.com/simp/pupmod-simp-simp_bolt/pull/10, there is still work to be done on simp_bolt:ainstall:

  • The yum install and plan logic still does some surprising things

    • See comments in PR#10 for some examples

    • A contributing factor to the convoluted logic may be how complex the code is.

    • It should be easy to refactor into something more idiomatic and simple to follow.

  • The plan output for several cases is absent or misleading

    • There is no summary of what happened to the nodes

    • Upload error messages don't specify the file when it is missing

    • After upgrading or installing, there's no output to show the current version.

    • The stdout out::message messages aren't in JSON formate when --format json

      • Use Puppet

  • The plan and task should probably be renamed to something more human-friendly

  • The helper task should:

    1. have metadata

    2. be private

    3. validate parameters

Acceptance Criteria

None

Epic Link

None

Story Points

None

Components

Assignee

Chris Tessmer

Priority

Medium
Configure