The upcoming release of Facter 4 has the potential to blow up our tests if we don't have factsets at the ready.
rspec-puppet-facts announcement: https://groups.io/g/voxpupuli/message/313
Facter 4 releases: https://github.com/puppetlabs/facter-ng/releases
We already have beaker tests in place to help us generate our facts so this should not be too much of a burden.
On a related thought: Our common Gemfile for simp modules currently leaves the facter version to the puppet gem's dependencies.
That means a gem release of Facter 4 could blow up our Puppet 6 module spec tests:
But a gem release of Facter 4 shouldn't blow up the Puppet 5 module spec tests:
Should our Gemfiles should also adopt the FACTER_GEM_VERSION environment variable mentioned in https://groups.io/g/voxpupuli/message/313?
In addition to generating new factsets, we will also need to loosen up the gem's dependencies to permit Facter 4 during testing: https://github.com/simp/rubygem-simp-rspec-puppet-facts/blob/3.1.1/simp-rspec-puppet-facts.gemspec#L24