SVCKill not working as expected

Description

It appears the the services type was updated in puppet between 5.5.6 and 5.5.20.

The services instances now returns all services including those marked bad and those marked as static so it is trying to kill lots of stuff that maybe we shouldn't.

Old 5.5.6 code in puppet service provider:
def self.instances
i = []
output = systemctl('list-unit-files', '--type', 'service', '--full', '--all', '--no-pager')
output.scan(/^(\S+)\s+(disabled|enabled|masked|indirect)\s*$/i).each do |m|
i << new(:name => m[0])
end
return i
rescue Puppet::ExecutionFailure
return []
end

New code in 5.5.21 (the release for 6.5)

def self.instances
i = []
output = systemctl('list-unit-files', '--type', 'service', '--full', '--all', '--no-pager')
output.scan(/^(\S+)\s+(disabled|enabled|masked|indirect|bad|static)\s*$/i).each do |m|
Puppet.debug("#{m[0]} marked as bad by `systemctl`. It is recommended to be further checked.") if m[1] == "bad"
i << new(:name => m[0])
end
return i
rescue Puppet::ExecutionFailure
return []
end

So we need to update svckill.

Acceptance Criteria

None

Labels

None

Epic Link

None

Story Points

None

Components

Assignee

Jeanne Greulich

Sprint

None

Affects versions

Priority

Medium
Configure