In pupmod_simp_pupmod::master at line 336 it looking for the values for
fact puppet_settings.master.user but it looks like Puppet has renamed them from
Puppet.settings[master] to Puppet.settings[server]. So when the simplib fact
puppet_settings is reading Puppet.settings, what used to go in puppet_settings hash under the "master" key is under the "server" key.
Looks like it changes in Puppet 6.19.0.
Do we make a copy of server to master in puppet_settings when the fact is created in simplib? "master' is still a valid section according to the code but seems to be empty, but that is just from looking at my instance not going through the puppet/settings.rb code. Or should we check for both in pupmod?
(I grepped the code and only found puppet_settings[master] to be used in pupmod, but it used in several manifests within pupmod.)
I would probably use dig() and check for server and then fall back to master if nothing is found.